fix: no dynamic connection when deregister does nothing#3697
Merged
albinsuresh merged 1 commit intothin-edge:mainfrom Jun 24, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
Contributor
Robot Results
|
| if message.retain && !message.payload_bytes().is_empty() { | ||
| if message.retain | ||
| && !message.payload_bytes().is_empty() | ||
| && topics.accept(&message) |
Contributor
There was a problem hiding this comment.
Can mqtt_connector.connect(topics) returns messages which are not related to the given topics?
Contributor
Author
There was a problem hiding this comment.
Technically no (which is what I was relying on as well). Just added this extra guard to prevent issues like what James encountered, where unexpected subscriptions got added to the connection behind the scenes. So, thought of leaving it there as a defence to prevent some future bug breaking the assumptions made here.
8f7ed5b to
e585642
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Types of changes
Paste Link to the issue
Checklist
just prepare-devonce)just formatas mentioned in CODING_GUIDELINESjust checkas mentioned in CODING_GUIDELINESFurther comments