Skip to content

chore: tedge diag's tarball path prints out to stdout#3696

Merged
rina23q merged 1 commit intothin-edge:mainfrom
rina23q:improve/3646/tedge-diag-prints-output-dir-to-stdout
Jun 20, 2025
Merged

chore: tedge diag's tarball path prints out to stdout#3696
rina23q merged 1 commit intothin-edge:mainfrom
rina23q:improve/3646/tedge-diag-prints-output-dir-to-stdout

Conversation

@rina23q
Copy link
Copy Markdown
Member

@rina23q rina23q commented Jun 18, 2025

Proposed changes

Only the tarball path prints out to stdout to make the following usecase work.

OUTPUT_PATH=$(tedge diag collect --name some_file_name)
tedge upload c8y --file "$OUTPUT_PATH"

# or in a one-liner
tedge upload c8y --file "$(tedge diag collect)"

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

#3646

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s. You can activate automatic signing by running just prepare-dev once)
  • I ran just format as mentioned in CODING_GUIDELINES
  • I used just check as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@rina23q rina23q temporarily deployed to Test Pull Request June 18, 2025 16:02 — with GitHub Actions Inactive
@rina23q rina23q added theme:troubleshooting Theme: Troubleshooting and remote control skip-release-notes Don't include the ticket in the auto generated release notes labels Jun 18, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 18, 2025

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
651 0 3 651 100 1h52m45.481654999s

Copy link
Copy Markdown
Contributor

@reubenmiller reubenmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, small change but it enables nicer integration with other tooling

Copy link
Copy Markdown
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Signed-off-by: Rina Fujino <rina.fujino.23@gmail.com>
@rina23q rina23q force-pushed the improve/3646/tedge-diag-prints-output-dir-to-stdout branch from a68a83b to 3fe5fff Compare June 20, 2025 11:22
@rina23q rina23q temporarily deployed to Test Pull Request June 20, 2025 11:22 — with GitHub Actions Inactive
@rina23q rina23q enabled auto-merge June 20, 2025 11:23
@rina23q rina23q added this pull request to the merge queue Jun 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 20, 2025
@rina23q rina23q added this pull request to the merge queue Jun 20, 2025
Merged via the queue into thin-edge:main with commit 734af48 Jun 20, 2025
34 checks passed
@rina23q rina23q deleted the improve/3646/tedge-diag-prints-output-dir-to-stdout branch August 8, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-release-notes Don't include the ticket in the auto generated release notes theme:troubleshooting Theme: Troubleshooting and remote control

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants