Skip to content

fix: remove redundant raspberry pi sudoers rule#3683

Merged
reubenmiller merged 1 commit intothin-edge:mainfrom
reubenmiller:fix-remove-rasppi-sudoer-rule
Jun 13, 2025
Merged

fix: remove redundant raspberry pi sudoers rule#3683
reubenmiller merged 1 commit intothin-edge:mainfrom
reubenmiller:fix-remove-rasppi-sudoer-rule

Conversation

@reubenmiller
Copy link
Copy Markdown
Contributor

@reubenmiller reubenmiller commented Jun 13, 2025

Proposed changes

Remove Raspberry PI specific sudoer's rule which is redundant to the current non-raspberry pi specific sudoers rule.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s. You can activate automatic signing by running just prepare-dev once)
  • I ran just format as mentioned in CODING_GUIDELINES
  • I used just check as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@reubenmiller
remove outdated raspberry pi sudoers rule logic
18ec92e 
Signed-off-by: reubenmiller <reuben.d.miller@gmail.com>
@reubenmiller reubenmiller requested a review from rina23q as a code owner June 13, 2025 08:59
@reubenmiller reubenmiller temporarily deployed to Test Pull Request June 13, 2025 08:59 — with GitHub Actions Inactive
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@reubenmiller reubenmiller added theme:installation Theme: Installation topics labels Jun 13, 2025
@reubenmiller reubenmiller changed the title fix: remove outdated raspberry pi sudoers rule logic fix: remove redundant raspberry pi sudoers rule Jun 13, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 13, 2025 •
edited
Loading

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
641 0 3 641 100 1h53m44.911387999s

rina23q
rina23q approved these changes Jun 13, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@rina23q rina23q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reubenmiller reubenmiller added this pull request to the merge queue Jun 13, 2025
Merged via the queue into thin-edge:main with commit 9909b6e Jun 13, 2025
51 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rina23q rina23q rina23q approved these changes

Assignees

No one assigned

Labels

theme:installation Theme: Installation topics

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@reubenmiller @rina23q