Skip to content

fix: fix tedge-apt-plugin version mismatch error message#3672

Merged
reubenmiller merged 1 commit intothin-edge:mainfrom
reubenmiller:fix-issue-3671
Jun 6, 2025
Merged

fix: fix tedge-apt-plugin version mismatch error message#3672
reubenmiller merged 1 commit intothin-edge:mainfrom
reubenmiller:fix-issue-3671

Conversation

@reubenmiller
Copy link
Copy Markdown
Contributor

@reubenmiller reubenmiller commented Jun 5, 2025

Proposed changes

Fix a parsing bug in the tedge-apt-plugin where a package's version number was not being shown in full when it was in the format 1:2.3.4-1 (e.g. with a epoch prefix). The bug is due to the field delimiter also being a colon :, and the logic did not assume that the value could also contain a colon. Solved simply by using splitn(2, ":") instead of split(":").

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

#3671

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s. You can activate automatic signing by running just prepare-dev once)
  • I ran just format as mentioned in CODING_GUIDELINES
  • I used just check as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Signed-off-by: reubenmiller <reuben.d.miller@gmail.com>
@reubenmiller reubenmiller temporarily deployed to Test Pull Request June 5, 2025 15:29 — with GitHub Actions Inactive
@reubenmiller reubenmiller added the theme:software Theme: Software management label Jun 5, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 5, 2025

Codecov Report

Attention: Patch coverage is 96.00000% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
plugins/tedge_apt_plugin/src/module_check.rs 96.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 5, 2025

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
641 0 3 641 100 1h49m6.663662s

@reubenmiller reubenmiller added this pull request to the merge queue Jun 6, 2025
Merged via the queue into thin-edge:main with commit 49b1c76 Jun 6, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

theme:software Theme: Software management

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants