Skip to content

fix: missing operation file c8y-remote-access-plugin when installed on Alpine Linux#3669

Merged
reubenmiller merged 1 commit intothin-edge:mainfrom
reubenmiller:fix-c8y-remote-access-plugin-alpine-packaging
Jun 5, 2025
Merged

fix: missing operation file c8y-remote-access-plugin when installed on Alpine Linux#3669
reubenmiller merged 1 commit intothin-edge:mainfrom
reubenmiller:fix-c8y-remote-access-plugin-alpine-packaging

Conversation

@reubenmiller
Copy link
Copy Markdown
Contributor

@reubenmiller reubenmiller commented Jun 4, 2025

Proposed changes

Fix an issue where the c8y-remote-access-plugin's maintainer scripts are not executed on Alpine Linux due to the apk package only containing a post-installation script (no actual files) which calls the c8y-remote-access-plugin --init which creates the required operation handler file. This resulted in the Remote Access not appearing in Cumulocity as the operation definition was missing.

To avoid this problem, the c8y_RemoteAccessConnect operation definition is being added to each of the linux packages (for consistency across deb, rpm and apk), to avoid this problem. The init command can still be run as it can correct any potential file ownership issues that may have changed over time on the user's device.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

#3667

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s. You can activate automatic signing by running just prepare-dev once)
  • I ran just format as mentioned in CODING_GUIDELINES
  • I used just check as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@reubenmiller reubenmiller requested a review from rina23q as a code owner June 4, 2025 14:38
@reubenmiller reubenmiller added the theme:packaging Theme: Packaging and release artefact topics label Jun 4, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@reubenmiller reubenmiller marked this pull request as draft June 4, 2025 14:52
@reubenmiller reubenmiller force-pushed the fix-c8y-remote-access-plugin-alpine-packaging branch from 90d0c5a to 09f7083 Compare June 4, 2025 15:20
@reubenmiller reubenmiller temporarily deployed to Test Pull Request June 4, 2025 15:20 — with GitHub Actions Inactive
@reubenmiller reubenmiller marked this pull request as ready for review June 4, 2025 15:25
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 4, 2025

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
641 0 3 641 100 1h49m5.264926999s

On Alpine Linux, if a package does not contain a file, the maintainer scripts
won't be executed, which results in the c8y_RemoteAccessConnect
not being created under the expected operations folder.

Resolves thin-edge#3667

Signed-off-by: reubenmiller <reuben.d.miller@gmail.com>
@reubenmiller reubenmiller force-pushed the fix-c8y-remote-access-plugin-alpine-packaging branch from 09f7083 to c5d1ae2 Compare June 4, 2025 20:01
@reubenmiller reubenmiller temporarily deployed to Test Pull Request June 4, 2025 20:01 — with GitHub Actions Inactive
Copy link
Copy Markdown
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@reubenmiller reubenmiller added this pull request to the merge queue Jun 5, 2025
Merged via the queue into thin-edge:main with commit fc92307 Jun 5, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

theme:packaging Theme: Packaging and release artefact topics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants