Skip to content

refactor: rename option for output tarball name#3662

Merged
rina23q merged 1 commit intothin-edge:mainfrom
rina23q:improve/rename-tarball-name-option-to-just-name
Jun 3, 2025
Merged

refactor: rename option for output tarball name#3662
rina23q merged 1 commit intothin-edge:mainfrom
rina23q:improve/rename-tarball-name-option-to-just-name

Conversation

@rina23q
Copy link
Copy Markdown
Member

@rina23q rina23q commented Jun 2, 2025

Proposed changes

Rename an option of diagnostic CLI from --tarball-name to --name as suggested by @albinsuresh.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

Bullet point 5. of #3646 (comment)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s. You can activate automatic signing by running just prepare-dev once)
  • I ran just format as mentioned in CODING_GUIDELINES
  • I used just check as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@rina23q
refactor: rename option for output tarball name
ad22d5b 
Signed-off-by: Rina Fujino <rina.fujino.23@gmail.com>
@rina23q rina23q temporarily deployed to Test Pull Request June 2, 2025 13:26 — with GitHub Actions Inactive
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
crates/core/tedge/src/cli/diag/cli.rs 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rina23q rina23q mentioned this pull request Jun 2, 2025
Closed
7 tasks
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 2, 2025

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
641 0 3 641 100 1h50m9.549232s

Bravo555
Bravo555 approved these changes Jun 2, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@Bravo555 Bravo555 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

albinsuresh
albinsuresh approved these changes Jun 3, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@albinsuresh albinsuresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

reubenmiller
reubenmiller approved these changes Jun 3, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@reubenmiller reubenmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@rina23q rina23q added this pull request to the merge queue Jun 3, 2025
Merged via the queue into thin-edge:main with commit dcbf85c Jun 3, 2025
34 checks passed
@rina23q rina23q added theme:cli Theme: cli related topics theme:troubleshooting Theme: Troubleshooting and remote control labels Jun 3, 2025
@rina23q rina23q deleted the improve/rename-tarball-name-option-to-just-name branch June 3, 2025 12:05
@reubenmiller reubenmiller added the skip-release-notes Don't include the ticket in the auto generated release notes label Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albinsuresh albinsuresh albinsuresh approved these changes

@reubenmiller reubenmiller reubenmiller approved these changes

@Bravo555 Bravo555 Bravo555 approved these changes

@didier-wenzek didier-wenzek Awaiting requested review from didier-wenzek didier-wenzek is a code owner

@jarhodes314 jarhodes314 Awaiting requested review from jarhodes314 jarhodes314 is a code owner

Assignees

No one assigned

Labels

skip-release-notes Don't include the ticket in the auto generated release notes theme:cli Theme: cli related topics theme:troubleshooting Theme: Troubleshooting and remote control

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rina23q @albinsuresh @reubenmiller @Bravo555