refactor: remove redundant use_basic_auth checks#3657
Merged
rina23q merged 1 commit intothin-edge:mainfrom Jun 2, 2025
Merged
Conversation
Signed-off-by: Rina Fujino <rina.fujino.23@gmail.com>
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
Contributor
Robot Results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
At some point,
bridge_configstarted holdingauth_type. This allows us to simplify thetedge connectimplementation.This PR is purely a refactoring; no behavioral changes are expected.
Note:
crates/core/tedge/src/cli/connect/command.rscontains methods which are used only by c8y. I think we can move such methods to underc8ymodule. This will control the feature flag for clouds easier.Types of changes
Paste Link to the issue
Checklist
just prepare-devonce)just formatas mentioned in CODING_GUIDELINESjust checkas mentioned in CODING_GUIDELINESFurther comments