Skip to content

refactor: remove redundant use_basic_auth checks#3657

Merged
rina23q merged 1 commit intothin-edge:mainfrom
rina23q:refactor/cleanup-use_basic_auth-conditions
Jun 2, 2025
Merged

refactor: remove redundant use_basic_auth checks#3657
rina23q merged 1 commit intothin-edge:mainfrom
rina23q:refactor/cleanup-use_basic_auth-conditions

Conversation

@rina23q
Copy link
Copy Markdown
Member

@rina23q rina23q commented May 30, 2025

Proposed changes

At some point, bridge_config started holding auth_type. This allows us to simplify the tedge connect implementation.

This PR is purely a refactoring; no behavioral changes are expected.


Note: crates/core/tedge/src/cli/connect/command.rs contains methods which are used only by c8y. I think we can move such methods to under c8y module. This will control the feature flag for clouds easier.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s. You can activate automatic signing by running just prepare-dev once)
  • I ran just format as mentioned in CODING_GUIDELINES
  • I used just check as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Signed-off-by: Rina Fujino <rina.fujino.23@gmail.com>
@codecov
Copy link
Copy Markdown

codecov bot commented May 30, 2025

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
crates/core/tedge/src/cli/connect/command.rs 0.00% 23 Missing ⚠️
crates/core/tedge/src/cli/connect/c8y.rs 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 30, 2025

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
640 0 3 640 100 1h53m26.864465s

Copy link
Copy Markdown
Contributor

@albinsuresh albinsuresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@rina23q rina23q added this pull request to the merge queue Jun 2, 2025
Merged via the queue into thin-edge:main with commit e4dca8f Jun 2, 2025
68 of 70 checks passed
@rina23q rina23q deleted the refactor/cleanup-use_basic_auth-conditions branch June 2, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactoring Developer value

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants