docs: Add JSON schema for MEA MQTT messages#3652
Merged
didier-wenzek merged 1 commit intothin-edge:mainfrom Jun 10, 2025
Merged
docs: Add JSON schema for MEA MQTT messages#3652didier-wenzek merged 1 commit intothin-edge:mainfrom
didier-wenzek merged 1 commit intothin-edge:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
albinsuresh
reviewed
Jun 6, 2025
| "type": "string" | ||
| } | ||
| }, | ||
| "$defs": { |
Contributor
There was a problem hiding this comment.
How about moving these shared types to a common.schema.json?
Contributor
Author
There was a problem hiding this comment.
I really prefer to keep things simple here, with independent schemas at the cost of a small redundancy.
albinsuresh
approved these changes
Jun 9, 2025
Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
643fdcb to
a7737e6
Compare
Contributor
Robot Results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add JSON schema for operationsReference these schema from the docsFor now, we simply keep these schemas underconfiguration/schemaand we will see later where is the better place to reference them.Types of changes
Paste Link to the issue
Checklist
just prepare-devonce)just formatas mentioned in CODING_GUIDELINESjust checkas mentioned in CODING_GUIDELINESFurther comments