Skip to content

test: PKCS11 connect using RSA keys of all sizes#3644

Merged
Bravo555 merged 2 commits intothin-edge:mainfrom
Bravo555:feat/pkcs11-rsa-keys
May 28, 2025
Merged

test: PKCS11 connect using RSA keys of all sizes#3644
Bravo555 merged 2 commits intothin-edge:mainfrom
Bravo555:feat/pkcs11-rsa-keys

Conversation

@Bravo555
Copy link
Copy Markdown
Member

@Bravo555 Bravo555 commented May 27, 2025 •
edited
Loading

Proposed changes

Add a test checking that we can connect to Cumulocity using PKCS11 RSA private keys of size: 1024 bits, 2048 bits, 3072 bits and 4096 bits.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s. You can activate automatic signing by running just prepare-dev once)
  • I ran just format as mentioned in CODING_GUIDELINES
  • I used just check as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@Bravo555 Bravo555 temporarily deployed to Test Pull Request May 27, 2025 08:05 — with GitHub Actions Inactive
@codecov
Copy link
Copy Markdown

codecov bot commented May 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 27, 2025 •
edited
Loading

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
635 0 3 635 100 1h48m8.947629s

@Bravo555 Bravo555 marked this pull request as ready for review May 27, 2025 08:50
@Bravo555 Bravo555 requested a review from a team as a code owner May 27, 2025 08:50
Bravo555 added 2 commits May 27, 2025 08:53
@Bravo555
refactor(test): improve pkcs11 ecdsa test
bc57ebe 
Signed-off-by: Marcel Guzik <marcel.guzik@cumulocity.com>
@Bravo555
test: PKCS11 connect using RSA keys of all sizes
722569f 
Signed-off-by: Marcel Guzik <marcel.guzik@cumulocity.com>
@Bravo555 Bravo555 force-pushed the feat/pkcs11-rsa-keys branch from 91f6e34 to 722569f Compare May 27, 2025 08:55
@Bravo555 Bravo555 temporarily deployed to Test Pull Request May 27, 2025 08:55 — with GitHub Actions Inactive
@Bravo555 Bravo555 added theme:security Theme: Security related topics theme:hsm Hardware Security Module related topics labels May 27, 2025
@reubenmiller reubenmiller added the theme:testing Theme: Testing label May 27, 2025
reubenmiller
reubenmiller approved these changes May 27, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@reubenmiller reubenmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Thanks for adding coverage for the different key lengths

@Bravo555 Bravo555 added this pull request to the merge queue May 28, 2025
Merged via the queue into thin-edge:main with commit 2742153 May 28, 2025
51 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reubenmiller reubenmiller reubenmiller approved these changes

Assignees

No one assigned

Labels

theme:hsm Hardware Security Module related topics theme:security Theme: Security related topics theme:testing Theme: Testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Bravo555 @reubenmiller