Skip to content

docs: remove unused/unreferences images and dev task#3639

Merged
reubenmiller merged 2 commits intothin-edge:mainfrom
reubenmiller:docs-remove-unused-images
May 23, 2025
Merged

docs: remove unused/unreferences images and dev task#3639
reubenmiller merged 2 commits intothin-edge:mainfrom
reubenmiller:docs-remove-unused-images

Conversation

@reubenmiller
Copy link
Copy Markdown
Contributor

@reubenmiller reubenmiller commented May 23, 2025

Proposed changes

Add a new justfile task (and script) to use ripgrep to find images within the project which aren't referenced anywhere and to delete them.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s. You can activate automatic signing by running just prepare-dev once)
  • I ran just format as mentioned in CODING_GUIDELINES
  • I used just check as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Signed-off-by: reubenmiller <reuben.d.miller@gmail.com>
@reubenmiller reubenmiller requested review from a team, Bravo555 and didier-wenzek as code owners May 23, 2025 11:19
@reubenmiller reubenmiller added the documentation Improvements or additions to documentation label May 23, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented May 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: reubenmiller <reuben.d.miller@gmail.com>
@reubenmiller reubenmiller force-pushed the docs-remove-unused-images branch from 0bb0292 to 3b0a68d Compare May 23, 2025 11:35
@reubenmiller reubenmiller temporarily deployed to Test Pull Request May 23, 2025 11:35 — with GitHub Actions Inactive
@reubenmiller reubenmiller enabled auto-merge May 23, 2025 11:43
@github-actions
Copy link
Copy Markdown
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
634 0 3 634 100 1h48m47.076926999s

@reubenmiller reubenmiller added this pull request to the merge queue May 23, 2025
Copy link
Copy Markdown
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

echo "No references for: $line" >&2

if [ "$DELETE" = 1 ]; then
find . -name "$line" -delete
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might delete more than one file. But yeah, none of them is referenced from source code. Okay, then.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah not the cleanest, but figured it was okish for a task which is only run on demand.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 23, 2025
@reubenmiller reubenmiller added this pull request to the merge queue May 23, 2025
Merged via the queue into thin-edge:main with commit f5c7862 May 23, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants