Skip to content

refactor: use a single function to find key#3622

Merged
Bravo555 merged 1 commit intothin-edge:mainfrom
Bravo555:refactor/pkcs11-get-key
May 15, 2025
Merged

refactor: use a single function to find key#3622
Bravo555 merged 1 commit intothin-edge:mainfrom
Bravo555:refactor/pkcs11-get-key

Conversation

@Bravo555
Copy link
Copy Markdown
Member

@Bravo555 Bravo555 commented May 14, 2025

Proposed changes

Remove get_key_type function and use a single function to find a key. When the URI is empty, the behaviour is the same as get_key_type.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s. You can activate automatic signing by running just prepare-dev once)
  • I ran just format as mentioned in CODING_GUIDELINES
  • I used just check as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@Bravo555
refactor: use a single function to find key
26ada14 
Remove `get_key_type` function and use a single function to find a key.
When the URI is empty, the behaviour is the same as `get_key_type`.

Signed-off-by: Marcel Guzik <marcel.guzik@cumulocity.com>
@Bravo555 Bravo555 added the refactoring Developer value label May 14, 2025
@Bravo555 Bravo555 temporarily deployed to Test Pull Request May 14, 2025 13:01 — with GitHub Actions Inactive
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 14, 2025

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
631 0 3 631 100 1h48m43.628369s

@codecov
Copy link
Copy Markdown

codecov bot commented May 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
crates/extensions/tedge-p11-server/src/pkcs11.rs 0.00% 23 Missing ⚠️

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

didier-wenzek
didier-wenzek approved these changes May 15, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Bravo555 Bravo555 added this pull request to the merge queue May 15, 2025
Merged via the queue into thin-edge:main with commit ab37411 May 15, 2025
34 checks passed
@Bravo555 Bravo555 deleted the refactor/pkcs11-get-key branch May 15, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@didier-wenzek didier-wenzek didier-wenzek approved these changes

@albinsuresh albinsuresh Awaiting requested review from albinsuresh albinsuresh is a code owner

@jarhodes314 jarhodes314 Awaiting requested review from jarhodes314 jarhodes314 is a code owner

@rina23q rina23q Awaiting requested review from rina23q rina23q is a code owner

Assignees

No one assigned

Labels

refactoring Developer value

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Bravo555 @didier-wenzek