Skip to content

refactor: reinstate private key zeroisation#3621

Merged
jarhodes314 merged 1 commit intothin-edge:mainfrom
jarhodes314:refactor/reinstate-rustls-zeroize
May 14, 2025
Merged

refactor: reinstate private key zeroisation#3621
jarhodes314 merged 1 commit intothin-edge:mainfrom
jarhodes314:refactor/reinstate-rustls-zeroize

Conversation

@jarhodes314
Copy link
Copy Markdown
Contributor

@jarhodes314 jarhodes314 commented May 14, 2025

Proposed changes

There's now been a rustls-pki-types release since rustls/pki-types#71 was merged, so this adopts those changes meaning we can once again zeroize the private key.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s. You can activate automatic signing by running just prepare-dev once)
  • I ran just format as mentioned in CODING_GUIDELINES
  • I used just check as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@jarhodes314
refactor: reinstate private key zeroisation
e1262cd 
Signed-off-by: James Rhodes <jarhodes314@gmail.com>
@jarhodes314 jarhodes314 temporarily deployed to Test Pull Request May 14, 2025 11:10 — with GitHub Actions Inactive
@reubenmiller reubenmiller added the refactoring Developer value label May 14, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 14, 2025

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
633 0 3 633 100 1h48m46.47464s

didier-wenzek
didier-wenzek approved these changes May 14, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@jarhodes314 jarhodes314 added this pull request to the merge queue May 14, 2025
Merged via the queue into thin-edge:main with commit d3aadc4 May 14, 2025
32 checks passed
@codecov
Copy link
Copy Markdown

codecov bot commented May 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
crates/common/mqtt_channel/src/config.rs 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@didier-wenzek didier-wenzek didier-wenzek approved these changes

@albinsuresh albinsuresh Awaiting requested review from albinsuresh albinsuresh is a code owner

@rina23q rina23q Awaiting requested review from rina23q rina23q is a code owner

@reubenmiller reubenmiller Awaiting requested review from reubenmiller reubenmiller is a code owner

Assignees

No one assigned

Labels

refactoring Developer value

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jarhodes314 @didier-wenzek @reubenmiller