Skip to content

fix: accept values starting with hypen in flags related to passwords#3619

Merged
reubenmiller merged 1 commit intothin-edge:mainfrom
reubenmiller:fix-password-allow-starting-with-hypen
May 14, 2025
Merged

fix: accept values starting with hypen in flags related to passwords#3619
reubenmiller merged 1 commit intothin-edge:mainfrom
reubenmiller:fix-password-allow-starting-with-hypen

Conversation

@reubenmiller
Copy link
Copy Markdown
Contributor

Proposed changes

Accept values provided to flags, which are related to passwords, to start with a hypen (to prevent cli parsing errors).

Only the password related flags were allowed for this, as other fields didn't make much sense starting with a hypen anyway.

The following commands should now work:

tedge cert download c8y --one-time-password "-example1234"
tedge cert upload c8y --password "-example1234"

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s. You can activate automatic signing by running just prepare-dev once)
  • I ran just format as mentioned in CODING_GUIDELINES
  • I used just check as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Signed-off-by: reubenmiller <reuben.d.miller@gmail.com>
@codecov
Copy link
Copy Markdown

codecov bot commented May 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
631 0 3 631 100 1h47m44.035891s

Copy link
Copy Markdown
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@reubenmiller reubenmiller added this pull request to the merge queue May 14, 2025
Merged via the queue into thin-edge:main with commit 8ee0910 May 14, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

theme:cli Theme: cli related topics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants