Skip to content

test: Update tests to check for maximum message counts only when appropriate#3615

Merged
jarhodes314 merged 1 commit intothin-edge:mainfrom
jarhodes314:fix/robot-test-operation-count
May 14, 2025
Merged

test: Update tests to check for maximum message counts only when appropriate#3615
jarhodes314 merged 1 commit intothin-edge:mainfrom
jarhodes314:fix/robot-test-operation-count

Conversation

@jarhodes314
Copy link
Copy Markdown
Contributor

Proposed changes

  • Re-enable some maximum message count assertions that were skipped while fix: fallback to systemctl command when debian helpers are not available #3402 was awaiting a fix
  • Remove the maximum message count assertion in the custom smartrest operation test. In the case of custom smartrest operations, the mapper makes no attempt to de-duplicate incoming operations, so we can't guarantee that an operation won't be executed twice, particularly in the case of system tests which run just after tedge has started up.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s. You can activate automatic signing by running just prepare-dev once)
  • I ran just format as mentioned in CODING_GUIDELINES
  • I used just check as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@jarhodes314 jarhodes314 requested a review from a team as a code owner May 13, 2025 16:01
@codecov
Copy link
Copy Markdown

codecov bot commented May 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@reubenmiller reubenmiller added the theme:testing Theme: Testing label May 13, 2025
@reubenmiller reubenmiller temporarily deployed to Test Pull Request May 13, 2025 17:07 — with GitHub Actions Inactive
@reubenmiller
Copy link
Copy Markdown
Contributor

@jarhodes314 I pushed another commit (ca9ae64) for a similar assertion related to the c8y-firmware-plugin which still uses the SmartREST topic to trigger a firmware update for child devices.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 13, 2025

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
633 0 3 633 100 1h50m16.858870999s

Copy link
Copy Markdown
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Copy link
Copy Markdown
Contributor

@reubenmiller reubenmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

…appropriate

Signed-off-by: James Rhodes <jarhodes314@gmail.com>
@jarhodes314 jarhodes314 force-pushed the fix/robot-test-operation-count branch from ca9ae64 to 95b67d2 Compare May 14, 2025 10:20
@jarhodes314 jarhodes314 temporarily deployed to Test Pull Request May 14, 2025 10:20 — with GitHub Actions Inactive
@jarhodes314 jarhodes314 enabled auto-merge May 14, 2025 10:35
@jarhodes314 jarhodes314 added this pull request to the merge queue May 14, 2025
Merged via the queue into thin-edge:main with commit cbb64d3 May 14, 2025
32 checks passed
@reubenmiller reubenmiller changed the title refactor: Update tests to check for maximum message counts only when appropriate test: Update tests to check for maximum message counts only when appropriate Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

theme:testing Theme: Testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants