Skip to content

docs: Fill in fallback values for sh command blocks#3611

Merged
reubenmiller merged 1 commit intothin-edge:mainfrom
Bravo555:docs/fill-missing-sh-blocks
May 13, 2025
Merged

docs: Fill in fallback values for sh command blocks#3611
reubenmiller merged 1 commit intothin-edge:mainfrom
Bravo555:docs/fill-missing-sh-blocks

Conversation

@Bravo555
Copy link
Copy Markdown
Member

Proposed changes

Fills in missing fallback text for sh command="tedge ..." blocks, which were generating fine locally, but were empty in the live docs because of missing thin-edge binaries.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

thin-edge/tedge-docs#110

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s. You can activate automatic signing by running just prepare-dev once)
  • I ran just format as mentioned in CODING_GUIDELINES
  • I used just check as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

thin-edge/tedge-docs#110

Signed-off-by: Marcel Guzik <marcel.guzik@cumulocity.com>
@Bravo555 Bravo555 requested a review from reubenmiller May 13, 2025 12:10
@Bravo555 Bravo555 requested a review from didier-wenzek as a code owner May 13, 2025 12:10
@Bravo555 Bravo555 temporarily deployed to Test Pull Request May 13, 2025 12:10 — with GitHub Actions Inactive
@codecov
Copy link
Copy Markdown

codecov bot commented May 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@reubenmiller reubenmiller enabled auto-merge May 13, 2025 12:41
@reubenmiller reubenmiller added documentation Improvements or additions to documentation theme:hsm Hardware Security Module related topics labels May 13, 2025
@github-actions
Copy link
Copy Markdown
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
631 0 3 631 100 1h48m27.178613s

@reubenmiller reubenmiller added this pull request to the merge queue May 13, 2025
Merged via the queue into thin-edge:main with commit 77dea1b May 13, 2025
34 checks passed
@Bravo555 Bravo555 deleted the docs/fill-missing-sh-blocks branch May 13, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation theme:hsm Hardware Security Module related topics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants