Skip to content

test: use new library keyword to get c8y domain#3604

Merged
reubenmiller merged 1 commit intothin-edge:mainfrom
reubenmiller:test-c8y-get-domain-helper
May 12, 2025
Merged

test: use new library keyword to get c8y domain#3604
reubenmiller merged 1 commit intothin-edge:mainfrom
reubenmiller:test-c8y-get-domain-helper

Conversation

@reubenmiller
Copy link
Copy Markdown
Contributor

@reubenmiller reubenmiller commented May 10, 2025 •
edited
Loading

Proposed changes

Use the new robotframework-c8y Get Domain keyword to normalize the usage in the tests (as there was also a previous bug in the sed usage).

Corresponding change in the RF library: thin-edge/robotframework-c8y#31

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s. You can activate automatic signing by running just prepare-dev once)
  • I ran just format as mentioned in CODING_GUIDELINES
  • I used just check as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@reubenmiller
test: get c8y domain using library keyword
c5be84e 
Signed-off-by: reubenmiller <reuben.d.miller@gmail.com>
@reubenmiller reubenmiller requested a review from a team as a code owner May 10, 2025 09:28
@reubenmiller reubenmiller temporarily deployed to Test Pull Request May 10, 2025 09:28 — with GitHub Actions Inactive
@reubenmiller reubenmiller added the theme:testing Theme: Testing label May 10, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented May 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 10, 2025

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
631 0 3 631 100 1h50m48.683899s

albinsuresh
albinsuresh approved these changes May 12, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@albinsuresh albinsuresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@reubenmiller reubenmiller added this pull request to the merge queue May 12, 2025
Merged via the queue into thin-edge:main with commit 1183dcc May 12, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albinsuresh albinsuresh albinsuresh approved these changes

Assignees

No one assigned

Labels

theme:testing Theme: Testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@reubenmiller @albinsuresh