fix: support HTTP proxy in c8y remote access plugin#3600
Merged
jarhodes314 merged 3 commits intothin-edge:mainfrom May 9, 2025
Merged
fix: support HTTP proxy in c8y remote access plugin#3600jarhodes314 merged 3 commits intothin-edge:mainfrom
jarhodes314 merged 3 commits intothin-edge:mainfrom
Conversation
Signed-off-by: James Rhodes <jarhodes314@gmail.com>
1a8cd28 to
957f742
Compare
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
Contributor
Robot Results
|
| let stream = TcpStream::connect(&host_port).await.into_diagnostic()?; | ||
| let mut stream = match address.scheme() { | ||
| ProxyScheme::Https => { | ||
| let connector: TlsConnector = config.clone().unwrap().into(); |
Contributor
There was a problem hiding this comment.
Could the config be None?
Contributor
Author
There was a problem hiding this comment.
Not in practice. In the unit tests, we set config to None in order to avoid TLS on the server it's hosting, but for the plugin code that calls this, we always have this value set
| assert_cmd = "2.0" | ||
| assert_matches = "1.5" | ||
| async-compat = "0.2.1" | ||
| async-http-proxy = "1.2" |
Contributor
There was a problem hiding this comment.
Being surprised to see that this has not been required sooner, notably for c8y_auth_proxy to connect c8y, I added a test 4391f1e. Indeed, this dependency is not required before because c8y_auth_proxy 's connection is opened by reqwest which is properly configured with the proxy when it applies.
Contributor
|
I've pushed a system test to verify the remote access access. |
reubenmiller
approved these changes
May 9, 2025
Contributor
reubenmiller
left a comment
There was a problem hiding this comment.
Approved (and tested it locally)
Signed-off-by: reubenmiller <reuben.d.miller@gmail.com>
Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
651d642 to
136e46e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Support the HTTP proxy configuration in the c8y remote access plugin. This was an accidental omission with the proxy feature.
Types of changes
Paste Link to the issue
Checklist
just prepare-devonce)just formatas mentioned in CODING_GUIDELINESjust checkas mentioned in CODING_GUIDELINESFurther comments