Skip to content

docs: Add tedge-p11-server reference and update hsm-support.md#3597

Merged
reubenmiller merged 4 commits intothin-edge:mainfrom
Bravo555:docs/tedge-p11-server
May 13, 2025
Merged

docs: Add tedge-p11-server reference and update hsm-support.md#3597
reubenmiller merged 4 commits intothin-edge:mainfrom
Bravo555:docs/tedge-p11-server

Conversation

@Bravo555
Copy link
Copy Markdown
Member

@Bravo555 Bravo555 commented May 6, 2025

Proposed changes

Update main HSM documentation page to remove outdated information and use tedge-p11-server and add a reference page about tedge-p11-server itself.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

#3594

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s. You can activate automatic signing by running just prepare-dev once)
  • I ran just format as mentioned in CODING_GUIDELINES
  • I used just check as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@Bravo555 Bravo555 had a problem deploying to Test Pull Request May 6, 2025 16:55 — with GitHub Actions Failure
@codecov
Copy link
Copy Markdown

codecov bot commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Bravo555 Bravo555 had a problem deploying to Test Pull Request May 7, 2025 11:21 — with GitHub Actions Failure
@Bravo555 Bravo555 temporarily deployed to Test Pull Request May 7, 2025 14:05 — with GitHub Actions Inactive
@Bravo555 Bravo555 marked this pull request as ready for review May 7, 2025 14:08
@Bravo555 Bravo555 requested a review from didier-wenzek as a code owner May 7, 2025 14:08
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 7, 2025

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
631 0 3 631 100 1h48m32.438663999s

Copy link
Copy Markdown
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would shorten the title to "Hardware Security Module (HSM)"

Copy link
Copy Markdown
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The draft flag can be removed on both pages as the feature is released now.

@Bravo555 Bravo555 had a problem deploying to Test Pull Request May 12, 2025 08:50 — with GitHub Actions Failure
@Bravo555 Bravo555 had a problem deploying to Test Pull Request May 12, 2025 10:27 — with GitHub Actions Failure
Copy link
Copy Markdown
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@reubenmiller reubenmiller added documentation Improvements or additions to documentation theme:hsm Hardware Security Module related topics labels May 13, 2025
Copy link
Copy Markdown
Contributor

@reubenmiller reubenmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall a very nice document, just a few minor consistency changes/markdown formatting.

@Bravo555 Bravo555 had a problem deploying to Test Pull Request May 13, 2025 07:31 — with GitHub Actions Failure
Copy link
Copy Markdown
Contributor

@reubenmiller reubenmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice additional to our docs

Bravo555 added 4 commits May 13, 2025 07:41
Signed-off-by: Marcel Guzik <marcel.guzik@cumulocity.com>
Signed-off-by: Marcel Guzik <marcel.guzik@cumulocity.com>
Signed-off-by: Marcel Guzik <marcel.guzik@cumulocity.com>
Signed-off-by: Marcel Guzik <marcel.guzik@cumulocity.com>
@Bravo555 Bravo555 force-pushed the docs/tedge-p11-server branch from 8a5180c to 0145526 Compare May 13, 2025 07:55
@Bravo555 Bravo555 temporarily deployed to Test Pull Request May 13, 2025 07:55 — with GitHub Actions Inactive
@reubenmiller reubenmiller enabled auto-merge May 13, 2025 08:21
@reubenmiller reubenmiller added this pull request to the merge queue May 13, 2025
Merged via the queue into thin-edge:main with commit 4df6116 May 13, 2025
34 checks passed
@Bravo555 Bravo555 deleted the docs/tedge-p11-server branch May 13, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation theme:hsm Hardware Security Module related topics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants