feat: append the option whether to add c8y_IsDevice to child devices#3560
Merged
rina23q merged 1 commit intothin-edge:mainfrom Apr 15, 2025
Conversation
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
Contributor
Robot Results
|
albinsuresh
approved these changes
Apr 14, 2025
Contributor
albinsuresh
left a comment
There was a problem hiding this comment.
Feel free to merge once the name is finalized.
albinsuresh
approved these changes
Apr 15, 2025
| pub bridge_health_topic: Topic, | ||
| pub smartrest_use_operation_id: bool, | ||
| pub smartrest_child_append_device_fragment: bool, | ||
| pub smartrest_child_device_create_with_device_marker: bool, |
Contributor
There was a problem hiding this comment.
Not a request for change: I'm just surprised clippy isn't freaking out with that name 😉.
reubenmiller
approved these changes
Apr 15, 2025
Contributor
reubenmiller
left a comment
There was a problem hiding this comment.
Approved. It worked as expected (when testing it on a tenant that supports the new SmartREST 2.0 template)
The static SmartREST template 101 is extended to accept boolean if a newly created child device should hold the `c8y_IsDevice` fragment. This change adds a new tedge configuration to control it. Signed-off-by: Rina Fujino <rina.fujino.23@gmail.com>
70a4a5d to
36998d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The static SmartREST template 101 is extended to accept boolean if a newly created child device should hold the
c8y_IsDevicefragment.This change adds a new tedge configuration to control it.
todos:
c8y.smartrest.child_device.create_with_device_markerAdd (or modify if needed) a system test-> eu-latest is not supporting this new feature yet anywayTypes of changes
Paste Link to the issue
#3487
Checklist
just prepare-devonce)just formatas mentioned in CODING_GUIDELINESjust checkas mentioned in CODING_GUIDELINESFurther comments