Skip to content

fix: improve accessibility of tedge cert show#3527

Merged
didier-wenzek merged 1 commit intothin-edge:mainfrom
didier-wenzek:fix/cert-show-accessibility
Apr 2, 2025
Merged

fix: improve accessibility of tedge cert show#3527
didier-wenzek merged 1 commit intothin-edge:mainfrom
didier-wenzek:fix/cert-show-accessibility

Conversation

@didier-wenzek
Copy link
Copy Markdown
Contributor

Proposed changes

Improve accessibility of tedge cert show: do not rely on color to distinguish a certificate which will expire soon from a certificate still valid for a safe period of time.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

#3526

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s. You can activate automatic signing by running just prepare-dev once)
  • I ran just format as mentioned in CODING_GUIDELINES
  • I used just check as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
@didier-wenzek didier-wenzek temporarily deployed to Test Pull Request April 2, 2025 09:43 — with GitHub Actions Inactive
@didier-wenzek didier-wenzek added improvement User value theme:cli Theme: cli related topics theme:certificates Theme: Device certificate topics labels Apr 2, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2025

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
crates/core/tedge/src/cli/certificate/show.rs 16.66% 5 Missing ⚠️

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2025

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
604 0 3 604 100 1h47m12.986323s

@didier-wenzek didier-wenzek added this pull request to the merge queue Apr 2, 2025
Merged via the queue into thin-edge:main with commit 8d5f4ca Apr 2, 2025
34 checks passed
@didier-wenzek didier-wenzek deleted the fix/cert-show-accessibility branch April 2, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement User value theme:certificates Theme: Device certificate topics theme:cli Theme: cli related topics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants