fix: skip bridge status messages in aws/az mappers#3505
Merged
Ruadhri17 merged 2 commits intothin-edge:mainfrom Mar 31, 2025
Merged
fix: skip bridge status messages in aws/az mappers#3505Ruadhri17 merged 2 commits intothin-edge:mainfrom
Ruadhri17 merged 2 commits intothin-edge:mainfrom
Conversation
Signed-off-by: Krzysztof Piotrowski <krzysztof.piotrowski@inetum.com>
e046354 to
59295e3
Compare
Contributor
Robot Results
|
…s mappers Signed-off-by: Krzysztof Piotrowski <krzysztof.piotrowski@inetum.com>
59295e3 to
cbe8217
Compare
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
rina23q
approved these changes
Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Currently, we skip the conversion message when it comes on the
awsorazbridge status topics. However, this is not sufficient, as the mapper reacts to all bridge status topics. Moreover, it always fails if the payload cannot be parsed into theMap<String, Value>format.This PR changes the logic: instead of checking the topic, we now attempt to parse the payload as a
u8and check if value is 0 or 1. If so, we skip the conversion. For other payload formats, a more descriptive error message will be logged.Types of changes
Paste Link to the issue
Checklist
just prepare-devonce)just formatas mentioned in CODING_GUIDELINESjust checkas mentioned in CODING_GUIDELINESFurther comments