fix: use both mqtt and http address when validating connecting c8y tenant url#3502
Merged
reubenmiller merged 1 commit intothin-edge:mainfrom Mar 25, 2025
Merged
Conversation
Signed-off-by: reubenmiller <reuben.d.miller@gmail.com>
Bravo555
approved these changes
Mar 25, 2025
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
rina23q
approved these changes
Mar 25, 2025
Contributor
Robot Results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
When a custom Cumulocity domain is used (aka the Cumulocity enterprise feature), the HTTP and MQTT endpoints will differ, however thin-edge.io was previously only checking the MQTT endpoint against URL derived from the Cumulocity JWT (which has the HTTP URL). The error only resulted in an invalid warning being shown to the user, however it just adds noise and confusion for the user.
Now, both the HTTP and MQTT endpoints are compared to ensure that at least one of them match.
Types of changes
Paste Link to the issue
#3501
Checklist
just prepare-devonce)just formatas mentioned in CODING_GUIDELINESjust checkas mentioned in CODING_GUIDELINESFurther comments