Skip to content

fix: use both mqtt and http address when validating connecting c8y tenant url#3502

Merged
reubenmiller merged 1 commit intothin-edge:mainfrom
reubenmiller:fix-c8y-custom-domain-warning
Mar 25, 2025
Merged

fix: use both mqtt and http address when validating connecting c8y tenant url#3502
reubenmiller merged 1 commit intothin-edge:mainfrom
reubenmiller:fix-c8y-custom-domain-warning

Conversation

@reubenmiller
Copy link
Copy Markdown
Contributor

Proposed changes

When a custom Cumulocity domain is used (aka the Cumulocity enterprise feature), the HTTP and MQTT endpoints will differ, however thin-edge.io was previously only checking the MQTT endpoint against URL derived from the Cumulocity JWT (which has the HTTP URL). The error only resulted in an invalid warning being shown to the user, however it just adds noise and confusion for the user.

Now, both the HTTP and MQTT endpoints are compared to ensure that at least one of them match.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

#3501

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s. You can activate automatic signing by running just prepare-dev once)
  • I ran just format as mentioned in CODING_GUIDELINES
  • I used just check as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Signed-off-by: reubenmiller <reuben.d.miller@gmail.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2025

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
crates/core/tedge/src/cli/connect/command.rs 0.00% 11 Missing ⚠️

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@github-actions
Copy link
Copy Markdown
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
600 0 3 600 100 1h42m0.034801999s

@reubenmiller reubenmiller added this pull request to the merge queue Mar 25, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 25, 2025
@reubenmiller reubenmiller added this pull request to the merge queue Mar 25, 2025
Merged via the queue into thin-edge:main with commit 410a6c0 Mar 25, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

theme:c8y Theme: Cumulocity related topics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants