fix: clear retained entity twin messages on deregister#3499
Merged
albinsuresh merged 1 commit intothin-edge:mainfrom Apr 12, 2025
Merged
Conversation
Contributor
Robot Results
|
d8f2118 to
a51180d
Compare
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
Comment on lines
+202
to
+206
| if let Channel::EntityTwinData { fragment_key } = channel { | ||
| let fragment_value = serde_json::from_slice(message.payload_bytes())?; | ||
| let twin_message = EntityTwinMessage::new(topic_id, fragment_key, fragment_value); | ||
| self.entity_store.update_twin_fragment(twin_message)?; | ||
| } |
Contributor
There was a problem hiding this comment.
I'm surprised by this bit. This is unrelated to the goal of this PR (clearing retained twin data messages on delete). And wasn't twin data already processed by the agent?
Contributor
Author
There was a problem hiding this comment.
Yes, I was surprised by that too. This bit got missed during the entity store migration. Writing the test for the bug highlighted this gap. This was never spotted because the entity cache of the mapper was still processing it properly. The twin_data maintained by the agent was somewhat unused so far, until now.
reubenmiller
approved these changes
Apr 3, 2025
Contributor
reubenmiller
left a comment
There was a problem hiding this comment.
Approved. Nice addition of the retained keyword for RobotFramework system tests.
cd477e6 to
bc0d8be
Compare
bc0d8be to
46bec66
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Clear retained twin data messages on entity deregister.
Types of changes
Paste Link to the issue
#3492
Checklist
just prepare-devonce)just formatas mentioned in CODING_GUIDELINESjust checkas mentioned in CODING_GUIDELINESFurther comments