Skip to content

fix: only warn if refresh-bridges fails during installation#3410

Merged
reubenmiller merged 1 commit intothin-edge:mainfrom
reubenmiller:fix-warn-on-refresh-bridges
Feb 20, 2025
Merged

fix: only warn if refresh-bridges fails during installation#3410
reubenmiller merged 1 commit intothin-edge:mainfrom
reubenmiller:fix-warn-on-refresh-bridges

Conversation

@reubenmiller
Copy link
Copy Markdown
Contributor

@reubenmiller reubenmiller commented Feb 19, 2025

Proposed changes

Since postinst failures can cause issues with packages manager (e.g. apt broken packages) which can make it harder to fix. The package status isn't dependent on the recreation of the bridge, so it shouldn't influence the install status.

The referenced ticket suggests a broader scope to improve the robustness to handle upgrade/configuration scenarios more securely, however these larger changes are not part of the scope of this PR. This PR just focuses on reducing immediate problems.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

#3408

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@reubenmiller reubenmiller added theme:installation Theme: Installation topics theme:packaging Theme: Packaging and release artefact topics labels Feb 19, 2025
Since postinst failures can cause issues with packages manager (e.g. apt broken packages) which can make it harder to fix. The package status isn't dependent on the recreation of the bridge, so it shouldn't influence the install status.

See thin-edge#3408
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 19, 2025

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
585 0 3 585 100 1h38m37.673960999s

Copy link
Copy Markdown
Contributor

@albinsuresh albinsuresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reubenmiller reubenmiller added this pull request to the merge queue Feb 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 20, 2025
@reubenmiller reubenmiller added this pull request to the merge queue Feb 20, 2025
Merged via the queue into thin-edge:main with commit 6249e5f Feb 20, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

theme:installation Theme: Installation topics theme:packaging Theme: Packaging and release artefact topics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants