fix: only warn if refresh-bridges fails during installation#3410
Merged
reubenmiller merged 1 commit intothin-edge:mainfrom Feb 20, 2025
Merged
Conversation
Since postinst failures can cause issues with packages manager (e.g. apt broken packages) which can make it harder to fix. The package status isn't dependent on the recreation of the bridge, so it shouldn't influence the install status. See thin-edge#3408
db57f97 to
7c7bb8b
Compare
Contributor
Robot Results
|
rina23q
approved these changes
Feb 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Since postinst failures can cause issues with packages manager (e.g. apt broken packages) which can make it harder to fix. The package status isn't dependent on the recreation of the bridge, so it shouldn't influence the install status.
The referenced ticket suggests a broader scope to improve the robustness to handle upgrade/configuration scenarios more securely, however these larger changes are not part of the scope of this PR. This PR just focuses on reducing immediate problems.
Types of changes
Paste Link to the issue
#3408
Checklist
cargo fmtas mentioned in CODING_GUIDELINEScargo clippyas mentioned in CODING_GUIDELINESFurther comments