fix: tedge mqtt panics on invalid MQTT topics#3396
Merged
didier-wenzek merged 1 commit intothin-edge:mainfrom Feb 12, 2025
Merged
fix: tedge mqtt panics on invalid MQTT topics#3396didier-wenzek merged 1 commit intothin-edge:mainfrom
didier-wenzek merged 1 commit intothin-edge:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is Additional details and impacted files📢 Thoughts on this report? Let us know! |
Contributor
Robot Results
|
albinsuresh
reviewed
Feb 12, 2025
| Sub { | ||
| /// Topic to subscribe to | ||
| topic: String, | ||
| #[arg(value_parser = TopicFilter::new)] |
Contributor
There was a problem hiding this comment.
Suggested change
| #[arg(value_parser = TopicFilter::new)] | |
| #[arg(value_parser = SimpleTopicFilter::new)] |
Without that, I didn't really get how the implicit conversion from TopicFilter into SimpleTopicFilter was happening.
Contributor
Author
There was a problem hiding this comment.
Yup ... leading to tons of failing tests. => fixed.
What's weird is that this compile fine.
Contributor
There was a problem hiding this comment.
What's weird is that this compile fine.
Yeah, I was also surprised by that.
Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
6798139 to
74960a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
tedge mqtt subtedge mqtt pubTypes of changes
Paste Link to the issue
#3395
Checklist
cargo fmtas mentioned in CODING_GUIDELINEScargo clippyas mentioned in CODING_GUIDELINESFurther comments