Skip to content

feat: log the auth method when running tedge connect c8y#3384

Merged
jarhodes314 merged 1 commit intothin-edge:mainfrom
jarhodes314:feat/log-auth-method
Feb 7, 2025
Merged

feat: log the auth method when running tedge connect c8y#3384
jarhodes314 merged 1 commit intothin-edge:mainfrom
jarhodes314:feat/log-auth-method

Conversation

@jarhodes314
Copy link
Copy Markdown
Contributor

@jarhodes314 jarhodes314 commented Feb 7, 2025

Proposed changes

Adds "auth method" and "credentials path" to tedge connect c8y output, and hides "certificate file" when this isn't used.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@jarhodes314 jarhodes314 added the theme:cli Theme: cli related topics label Feb 7, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 34 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
crates/core/tedge/src/cli/connect/command.rs 0.00% 18 Missing ⚠️
crates/core/tedge/src/cli/log.rs 0.00% 16 Missing ⚠️
Additional details and impacted files

📢 Thoughts on this report? Let us know!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 7, 2025

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
570 0 3 570 100 1h32m46.456938s

@reubenmiller reubenmiller changed the title log the auth method when running tedge connect c8y feat: log the auth method when running tedge connect c8y Feb 7, 2025
didier-wenzek
didier-wenzek approved these changes Feb 7, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Working as expected.

reubenmiller
reubenmiller approved these changes Feb 7, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@reubenmiller reubenmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Works nicely.

@reubenmiller reubenmiller added the theme:c8y Theme: Cumulocity related topics label Feb 7, 2025
@jarhodes314 jarhodes314 added this pull request to the merge queue Feb 7, 2025
Merged via the queue into thin-edge:main with commit 4f16ca8 Feb 7, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reubenmiller reubenmiller reubenmiller approved these changes

@didier-wenzek didier-wenzek didier-wenzek approved these changes

@albinsuresh albinsuresh Awaiting requested review from albinsuresh albinsuresh is a code owner

@rina23q rina23q Awaiting requested review from rina23q rina23q is a code owner

Assignees

No one assigned

Labels

theme:c8y Theme: Cumulocity related topics theme:cli Theme: cli related topics

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jarhodes314 @reubenmiller @didier-wenzek