feat: HSM auth - c8y connection init & built in bridge#3366
feat: HSM auth - c8y connection init & built in bridge#3366Bravo555 merged 7 commits intothin-edge:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is Additional details and impacted files📢 Thoughts on this report? Let us know! |
a308296 to
f0f2ceb
Compare
Robot Results
|
130ad99 to
6f4c513
Compare
6f4c513 to
41e025c
Compare
41e025c to
134cd6a
Compare
134cd6a to
ca5d6b9
Compare
ca5d6b9 to
143d7c4
Compare
49ba813 to
156d468
Compare
156d468 to
80343a2
Compare
80343a2 to
0a5b8e9
Compare
|
@Bravo555 We need to check the naming of the Some thoughts on the subject:
|
ae7153b to
a550fc0
Compare
4c67b49 to
bd30e79
Compare
bd30e79 to
057ce5b
Compare
057ce5b to
f1136cd
Compare
12583c2 to
127e759
Compare
127e759 to
d36b6c1
Compare
reubenmiller
left a comment
There was a problem hiding this comment.
Approved.
I've tested the latest changes using a Yubikey 5C and inside a container (using p11-kit server to setup a unix socket which is passed into the container)..the test was done using https://github.com/reubenmiller/hsm-research/tree/main/tedge.
Overall a nice addition to lay the groundwork for the next phase of implementation.
didier-wenzek
left a comment
There was a problem hiding this comment.
Approved. Thank you for taking on this PKCS#11 integration challenge. A first step but a decisive one.
Signed-off-by: Marcel Guzik <marcel.guzik@cumulocity.com>
This new draft reference document aims to track the state of HSM/PKCS#11 support in thin-edge and will be updated along with the implementation. Signed-off-by: Marcel Guzik <marcel.guzik@cumulocity.com>
Adding cryptoki configuration to the method is non-trivial and the method IMO doesn't provide much value anyway, since the errors it reports are going to be returned a bit later when the bridge actually tries to start. Signed-off-by: Marcel Guzik <marcel.guzik@cumulocity.com>
Signed-off-by: Marcel Guzik <marcel.guzik@cumulocity.com>
Signed-off-by: Marcel Guzik <marcel.guzik@cumulocity.com>
Signed-off-by: Marcel Guzik <marcel.guzik@cumulocity.com>
Signed-off-by: Marcel Guzik <marcel.guzik@cumulocity.com>
|
failed due to flaky test #3399; retrying merge |
TODO
add documentationwrote a reference doc and the draft of a user guide, subject to change because details related to the UNIX socket setup are still being hashed outresolve current hacks and workarounds in places where we assume private key always comes from a filethere were some hacks but they're now removedAdd new cargo feature called "cryptoki" where all of the dependencies related to the cryptoki are hidden below it (and the feature is not activated by default). Configuration can be marked as hidden until configuration names are agreed uponFollow-up items
device.cryptoki.enableistrue, but module path is not settedge connectsummaryrefactor TLS configuration setup2c27e33Proposed changes
Allow the use of Hardware Security Modules for MQTT client authentication when using c8y cloud.
We add the following config settings:
which are then used for configuring HSM authentication parameters.
Types of changes
Paste Link to the issue
#3363
Checklist
cargo fmtas mentioned in CODING_GUIDELINEScargo clippyas mentioned in CODING_GUIDELINESFurther comments