fix: ensure file transfer service always writes uploaded file#3364
Merged
jarhodes314 merged 1 commit intothin-edge:mainfrom Jan 28, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files📢 Thoughts on this report? Let us know! |
Contributor
Robot Results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes some flaky tests and a bug in the file transfer service where files were not uploaded in their entirety.
We were previously calling
.write, but ignoring the number of bytes written. Since we always want to write the entire chunk, I have replaced this with.write_all. In addition, I've added aBufWriterto improve the performance when writing files, and ensured this buffer is flushed before responding to the request.Types of changes
Paste Link to the issue
I've seen multiple failures locally, all of them exhibit the same "empty file" behaviour, and cannot reproduce any tedge-agent failures after applying the fix:
Checklist
cargo fmtas mentioned in CODING_GUIDELINEScargo clippyas mentioned in CODING_GUIDELINESFurther comments