fix: tedge cert create-csr should use cloud profile's CN#3316
Merged
rina23q merged 2 commits intothin-edge:mainfrom Jan 10, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files📢 Thoughts on this report? Let us know! |
Contributor
Robot Results
|
rina23q
commented
Jan 6, 2025
|
|
||
| // Use the current device id if no id is provided | ||
| let id = id.unwrap_or(get_device_id_from_cloud(&config, &cloud)?); | ||
| let id = if let Some(id) = id { |
Member
Author
There was a problem hiding this comment.
At first, I wrote this line as below.
let id = id.unwrap_or(get_device_id_from_cloud(&config, &cloud)?);However, it causes a problem when certificate doesn't exist but the id has Some() sinceunwrap_or() evaluates the default always regardless of id is Some or None.
Member
There was a problem hiding this comment.
Indeed, and unwrap_or_else, makes it so you can't use ? from within the closure, which is a bit of a pain.
f9bab9b to
5f6a6f2
Compare
Bravo555
approved these changes
Jan 8, 2025
|
|
||
| // Use the current device id if no id is provided | ||
| let id = id.unwrap_or(get_device_id_from_cloud(&config, &cloud)?); | ||
| let id = if let Some(id) = id { |
Member
There was a problem hiding this comment.
Indeed, and unwrap_or_else, makes it so you can't use ? from within the closure, which is a bit of a pain.
5f6a6f2 to
ed05f1d
Compare
Signed-off-by: Rina Fujino <rina.fujino.23@gmail.com>
…rofile Signed-off-by: Rina Fujino <rina.fujino.23@gmail.com>
ed05f1d to
a4d99a4
Compare
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
tedge cert create-csr <cloud> --profile <profile>should use the CN of the corresponding device certificate/private key if--device-idis not provided.Types of changes
Paste Link to the issue
#3315
Checklist
cargo fmtas mentioned in CODING_GUIDELINEScargo clippyas mentioned in CODING_GUIDELINESFurther comments