Skip to content

test: pretty print json payloads and disable robotidy to preserve leading whitespace#3314

Merged
reubenmiller merged 1 commit intothin-edge:mainfrom
reubenmiller:test-pretty-print-json-payloads
Jan 6, 2025
Merged

test: pretty print json payloads and disable robotidy to preserve leading whitespace#3314
reubenmiller merged 1 commit intothin-edge:mainfrom
reubenmiller:test-pretty-print-json-payloads

Conversation

@reubenmiller
Copy link
Copy Markdown
Contributor

Proposed changes

Improve readability of tests using large json payloads by formatting them via pretty print (with 2 spaces) and disabling the robotidy auto formatter for such lines. Previously the payloads were pretty printed but the robotidy auto formatter would strip the leading whitespace.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@reubenmiller reubenmiller requested a review from a team as a code owner January 6, 2025 09:31
@reubenmiller reubenmiller added the theme:testing Theme: Testing label Jan 6, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 6, 2025

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
551 0 2 551 100 1h31m26.789619s

Copy link
Copy Markdown
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@reubenmiller reubenmiller added this pull request to the merge queue Jan 6, 2025
Merged via the queue into thin-edge:main with commit fb7ff67 Jan 6, 2025
@reubenmiller reubenmiller deleted the test-pretty-print-json-payloads branch January 6, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

theme:testing Theme: Testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants