Skip to content

fix: cleanup empty profiles#3310

Merged
jarhodes314 merged 1 commit intothin-edge:mainfrom
jarhodes314:feat/multi-dto-cleanup
Dec 20, 2024
Merged

fix: cleanup empty profiles#3310
jarhodes314 merged 1 commit intothin-edge:mainfrom
jarhodes314:feat/multi-dto-cleanup

Conversation

@jarhodes314
Copy link
Copy Markdown
Contributor

Proposed changes

Clean up empty profiles when calling tedge config unset, e.g. running

tedge config set c8y.url example.com --profile test
tedge config unset c8y.url --profile test
tedge config list test # <- should return nothing

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Signed-off-by: James Rhodes <jarhodes314@gmail.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 93.60000% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
crates/common/tedge_config_macros/src/multi.rs 80.48% 6 Missing and 2 partials ⚠️
Additional details and impacted files

📢 Thoughts on this report? Let us know!

@github-actions
Copy link
Copy Markdown
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
551 0 2 551 100 1h32m35.966023999s

Copy link
Copy Markdown
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. This is working as expected.

@jarhodes314 jarhodes314 added this pull request to the merge queue Dec 20, 2024
Merged via the queue into thin-edge:main with commit a48c009 Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

theme:cli Theme: cli related topics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants