refactor: Simplify command state update methods#3309
Merged
didier-wenzek merged 3 commits intothin-edge:mainfrom Dec 19, 2024
Merged
refactor: Simplify command state update methods#3309didier-wenzek merged 3 commits intothin-edge:mainfrom
didier-wenzek merged 3 commits intothin-edge:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is Additional details and impacted files📢 Thoughts on this report? Let us know! |
Contributor
Robot Results
|
jarhodes314
approved these changes
Dec 19, 2024
| operation: &OperationType, | ||
| command_state: GenericCommandState, | ||
| ) -> Result<Option<GenericCommandState>, WorkflowExecutionError> { | ||
| let operation_name = operation.to_string(); |
Contributor
There was a problem hiding this comment.
Minor: I think to_owned better signifies the intent here
Suggested change
| let operation_name = operation.to_string(); | |
| let operation_name = operation.to_owned(); |
Contributor
Author
There was a problem hiding this comment.
to_owned() is not appropriate here.
To convey the intent, I replaced to_string() by name(): 33268b9
Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
In order to better convey the intent. Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
33268b9 to
b9fea1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Address comments raised on #3307
Types of changes
Paste Link to the issue
#3307
Checklist
cargo fmtas mentioned in CODING_GUIDELINEScargo clippyas mentioned in CODING_GUIDELINESFurther comments