fix: process non-versioned in-progress commands on startup#3306
Merged
reubenmiller merged 2 commits intothin-edge:mainfrom Dec 17, 2024
Merged
Conversation
Contributor
Robot Results
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files📢 Thoughts on this report? Let us know! |
…workflows on startup
When the agent restarts after a self-update, the workflow versions might not have been persisted for the pending commands (simply because the feature was not enabled by the former version of the agent). In such a case the current version of the workflow is assumed. Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
2098c5e to
f48eedd
Compare
didier-wenzek
approved these changes
Dec 17, 2024
| .and_then(|operation| self.workflows.get_mut(&operation.as_str().into())) | ||
| { | ||
| if let Some(current_version) = versions.use_current_version() { | ||
| *command = command.clone().set_workflow_version(current_version); |
Contributor
There was a problem hiding this comment.
Not so nice, but okayish as this happens only on very specific and rare cases (restart after a self update).
It would be nicer to change set_workflow_version signature:
Suggested change
| *command = command.clone().set_workflow_version(current_version); | |
| command.set_workflow_version(current_version); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fix handling of in-progress commands/workflows which originate from the tedge-agent prior to 1.4.0.
Types of changes
Paste Link to the issue
#3305
Checklist
cargo fmtas mentioned in CODING_GUIDELINEScargo clippyas mentioned in CODING_GUIDELINESFurther comments