feat: add c8y createBulk topics to bridge#3286
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files📢 Thoughts on this report? Let us know! |
Robot Results
|
8010224 to
d26826b
Compare
didier-wenzek
left a comment
There was a problem hiding this comment.
Approved.
For thin-edge point of view this is just a new bridge entry, so this is okay. But to be honest, I really don't see the point of this bulk API over MQTT. Bulk creation requests fully make sense over a request/response protocol where you expect back an identifier for each new items or when there is a transaction contract and atomicity requirements. But here, over MQTT, there is no responses, no returned ids, no atomic batch creation.
It's mainly useful for users who want to send a lot of measurements in one go. For instance, if there is a process which collects daily statistics (e.g. 10min averages) and wants to publish the day's values at the end of each day (I've seen this logic in wind turbines). Sending the measurements as individual measurements makes it harder to confirm that all of the day's measurements have been sent to the cloud. Whilst in the cloud, you still allow the users to query for the individual measurements (rather than grouping multiple data points into a single measurement). |
Proposed changes
Add Cumulocity bulk telemetry creattion topics to the bridge (both mosquitto bridge and built-in bridge):
This enables users to publish bulk measurements using the following topics:
See Cumulocity documentation for details.
Types of changes
Paste Link to the issue
#3203
Checklist
cargo fmtas mentioned in CODING_GUIDELINEScargo clippyas mentioned in CODING_GUIDELINESFurther comments