chore: fix rust 1.83 clippy lints#3272
Merged
Bravo555 merged 1 commit intothin-edge:mainfrom Nov 29, 2024
Merged
Conversation
2aa8ab9 to
e8b3fa5
Compare
jarhodes314
approved these changes
Nov 29, 2024
| panic!("No free port found") | ||
| } | ||
|
|
||
| #[expect(clippy::type_complexity)] |
Contributor
There was a problem hiding this comment.
Nice, I didn't realise expect existed!
Member
Author
There was a problem hiding this comment.
Yup, it was added relatively recently
Member
Author
There was a problem hiding this comment.
But I have to change it to #[allow] because of MSRV 😮💨
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files📢 Thoughts on this report? Let us know! |
Contributor
Robot Results
|
Signed-off-by: Marcel Guzik <marcel.guzik@inetum.com>
e8b3fa5 to
67c5127
Compare
didier-wenzek
approved these changes
Nov 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Types of changes
Paste Link to the issue
Checklist
cargo fmtas mentioned in CODING_GUIDELINEScargo clippyas mentioned in CODING_GUIDELINESFurther comments