Skip to content

fix: skip publishing error message if operation update is not required#3266

Merged
Ruadhri17 merged 1 commit intothin-edge:mainfrom
Ruadhri17:operation-update-redundant-message
Nov 27, 2024
Merged

fix: skip publishing error message if operation update is not required#3266
Ruadhri17 merged 1 commit intothin-edge:mainfrom
Ruadhri17:operation-update-redundant-message

Conversation

@Ruadhri17
Copy link
Copy Markdown
Contributor

Proposed changes

Currently we publish message to te/errors when /etc/tedge/operations/c8y directory was modified but no operation update is required. This might be misleading to users that there is something wrong with operations so this PR removes that message. Not other logging was introduced as this information should just be skipped.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Signed-off-by: Krzysztof Piotrowski <krzysztof.piotrowski@inetum.com>
Copy link
Copy Markdown
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@github-actions
Copy link
Copy Markdown
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
524 0 2 524 100 1h24m58.03806s

Copy link
Copy Markdown
Contributor

@albinsuresh albinsuresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ruadhri17 Ruadhri17 added this pull request to the merge queue Nov 27, 2024
Merged via the queue into thin-edge:main with commit 3b79acc Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants