fix: skip publishing error message if operation update is not required#3266
Merged
Ruadhri17 merged 1 commit intothin-edge:mainfrom Nov 27, 2024
Merged
Conversation
Signed-off-by: Krzysztof Piotrowski <krzysztof.piotrowski@inetum.com>
Contributor
Robot Results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Currently we publish message to
te/errorswhen/etc/tedge/operations/c8ydirectory was modified but no operation update is required. This might be misleading to users that there is something wrong with operations so this PR removes that message. Not other logging was introduced as this information should just be skipped.Types of changes
Paste Link to the issue
te/errorswhen there is a change on/etc/tedge/operations/c8y#3252Checklist
cargo fmtas mentioned in CODING_GUIDELINEScargo clippyas mentioned in CODING_GUIDELINESFurther comments