Skip to content

dev: publish devcontainer image#3265

Merged
reubenmiller merged 3 commits intothin-edge:mainfrom
reubenmiller:dev-publish-devcontainer
Nov 26, 2024
Merged

dev: publish devcontainer image#3265
reubenmiller merged 3 commits intothin-edge:mainfrom
reubenmiller:dev-publish-devcontainer

Conversation

@reubenmiller
Copy link
Copy Markdown
Contributor

Proposed changes

Publish the dev container to Github container registry to reduce the time it takes to install all of the dependencies to start developing. In addition it makes the dev environment more reliable as apt-get install performance can be unreliable at times as the automatic mirror selection does not always choose a close-by debian mirror.

A workflow has been added to also periodically publish the devcontainer image (or on demand).

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@reubenmiller reubenmiller added the theme:developer-exp Theme: improve developer experience label Nov 26, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 26, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
524 0 2 524 100 1h34m59.147034s

Copy link
Copy Markdown
Contributor

@albinsuresh albinsuresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reubenmiller reubenmiller force-pushed the dev-publish-devcontainer branch from 17bcd48 to 8e00c96 Compare November 26, 2024 18:43
@reubenmiller reubenmiller added this pull request to the merge queue Nov 26, 2024
Merged via the queue into thin-edge:main with commit 140f061 Nov 26, 2024
@reubenmiller reubenmiller deleted the dev-publish-devcontainer branch November 26, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

theme:developer-exp Theme: improve developer experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants