Skip to content

fix: tedge-agent error does not show which file does not exist#3223

Merged
didier-wenzek merged 1 commit intothin-edge:mainfrom
didier-wenzek:fix/io-error-with-missing-file-path
Nov 6, 2024
Merged

fix: tedge-agent error does not show which file does not exist#3223
didier-wenzek merged 1 commit intothin-edge:mainfrom
didier-wenzek:fix/io-error-with-missing-file-path

Conversation

@didier-wenzek
Copy link
Copy Markdown
Contributor

Proposed changes

Add path to io errors reading certificates

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

#3159

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 27.02703% with 27 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...s/common/certificate/src/parse_root_certificate.rs 7.40% 15 Missing and 10 partials ⚠️
crates/core/tedge/src/cli/certificate/create.rs 0.00% 2 Missing ⚠️
Additional details and impacted files

📢 Thoughts on this report? Let us know!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 5, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
529 0 2 529 100 1h34m30.674355999s

@reubenmiller reubenmiller added the theme:troubleshooting Theme: Troubleshooting and remote control label Nov 5, 2024
@didier-wenzek didier-wenzek added this pull request to the merge queue Nov 6, 2024
Merged via the queue into thin-edge:main with commit ab45404 Nov 6, 2024
@didier-wenzek didier-wenzek deleted the fix/io-error-with-missing-file-path branch November 6, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

theme:troubleshooting Theme: Troubleshooting and remote control

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants