fix: c8y http proxy wrongly assumes any hostname is from the same tenant#3222
Merged
didier-wenzek merged 1 commit intothin-edge:mainfrom Nov 5, 2024
Merged
Conversation
When configured with hostnames without domains, c8y_api::http_proxy::maybe_tenant_url wrongly assumes any hostname, given without a domain, is related to the same tenant. Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
Contributor
Robot Results
|
albinsuresh
approved these changes
Nov 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
When configured with hostnames without domains,
c8y_api::http_proxy::maybe_tenant_url wrongly assumes any hostname, given without a domain,
is related to the same tenant.
This was due to wrong defaults when parsing an url with no domain.
Types of changes
Paste Link to the issue
Checklist
cargo fmtas mentioned in CODING_GUIDELINEScargo clippyas mentioned in CODING_GUIDELINESFurther comments