feat: Add a warning about clearing command metadata being unsupported#3213
Merged
Bravo555 merged 1 commit intothin-edge:mainfrom Oct 30, 2024
Merged
Conversation
Replaces `ERROR: Mapping error: EOF while parsing a value at line 1 column 0` error log with a more meaningful warning log when publishing an empty message to a command metadata topic. There are some unresolved questions wrt. clearing command metadata (see discussion in thin-edge#2739), so for now we just provide a helpful message to the user. This feature will be implemented after the questions are resolved. Signed-off-by: Marcel Guzik <marcel.guzik@inetum.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files📢 Thoughts on this report? Let us know! |
albinsuresh
approved these changes
Oct 30, 2024
didier-wenzek
approved these changes
Oct 30, 2024
Contributor
didier-wenzek
left a comment
There was a problem hiding this comment.
Approved. Indeed, a nice improvement from a user perspective.
Contributor
Robot Results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Replaces
ERROR: Mapping error: EOF while parsing a value at line 1 column 0error log with a more meaningful warning log when publishing an empty message to a command metadata topic.There are some unresolved questions wrt. clearing command metadata (see discussion in #2739), so for now we just provide a helpful message to the user. This feature will be implemented after the questions are resolved.
Types of changes
Paste Link to the issue
#2739
Checklist
cargo fmtas mentioned in CODING_GUIDELINEScargo clippyas mentioned in CODING_GUIDELINESFurther comments
This PR was created so that the relevant issue can be closed, because the error message itself is not really a problem or a bug, but there's a much bigger design question about how clearing command capabilities should work, primarily when it comes to clearing capabilities of builtin agent commands. As such this PR provides a more meaningful warning to any users, while we can discuss the specifics. For that we can create a new, more design-focused issue about the capability clearing mechanism.