Skip to content

fix: agent stops processing on ill-formed software_update command payloads#3209

Merged
didier-wenzek merged 2 commits intothin-edge:mainfrom
didier-wenzek:fix/agent-skip-processing-ill-formed-software-updates
Oct 28, 2024
Merged

fix: agent stops processing on ill-formed software_update command payloads#3209
didier-wenzek merged 2 commits intothin-edge:mainfrom
didier-wenzek:fix/agent-skip-processing-ill-formed-software-updates

Conversation

@didier-wenzek
Copy link
Copy Markdown
Contributor

@didier-wenzek didier-wenzek commented Oct 28, 2024 •
edited
Loading

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

#3136

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 28, 2024 •
edited
Loading

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
525 0 2 525 100 1h39m51.747434s

@didier-wenzek didier-wenzek added bug Something isn't working theme:software Theme: Software management labels Oct 28, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Additional details and impacted files

📢 Thoughts on this report? Let us know!

@didier-wenzek didier-wenzek marked this pull request as ready for review October 28, 2024 17:31
@didier-wenzek
Reproduce thin-edge#3136
73f094d 
Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
@didier-wenzek
Accept unknown fields in software update commands
42d5b43 
Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
@didier-wenzek didier-wenzek force-pushed the fix/agent-skip-processing-ill-formed-software-updates branch from 1099f9e to 42d5b43 Compare October 28, 2024 17:46
@didier-wenzek didier-wenzek added this pull request to the merge queue Oct 28, 2024
Merged via the queue into thin-edge:main with commit 6145601 Oct 28, 2024
@didier-wenzek didier-wenzek deleted the fix/agent-skip-processing-ill-formed-software-updates branch October 28, 2024 21:11
@reubenmiller reubenmiller added this to the 1.4.0 milestone Dec 5, 2024
@reubenmiller reubenmiller changed the title fix: agent stops processing ill-formed software_update command payloads fix: agent stops processing on ill-formed software_update command payloads Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jarhodes314 jarhodes314 jarhodes314 approved these changes

@albinsuresh albinsuresh Awaiting requested review from albinsuresh albinsuresh is a code owner

@rina23q rina23q Awaiting requested review from rina23q rina23q is a code owner

@gligorisaev gligorisaev Awaiting requested review from gligorisaev

Assignees

No one assigned

Labels

bug Something isn't working theme:software Theme: Software management

Projects

None yet

Milestone

1.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@didier-wenzek @jarhodes314 @reubenmiller