Skip to content

fix: replace hardcoded topic prefix for SmartREST templates when creating bridge config#3198

Merged
Ruadhri17 merged 1 commit intothin-edge:mainfrom
Ruadhri17:bridge-fix-template-prefix
Oct 23, 2024
Merged

fix: replace hardcoded topic prefix for SmartREST templates when creating bridge config#3198
Ruadhri17 merged 1 commit intothin-edge:mainfrom
Ruadhri17:bridge-fix-template-prefix

Conversation

@Ruadhri17
Copy link
Copy Markdown
Contributor

@Ruadhri17 Ruadhri17 commented Oct 23, 2024

Proposed changes

This PR replace one hardcoded topic prefix in bridge config with the one from tedge config.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@Ruadhri17
fix: replace hardcoded topic prefix when creating bridge config
6105630 
Signed-off-by: Krzysztof Piotrowski <K.R.Piotrowski17@gmail.com>
@Ruadhri17 Ruadhri17 temporarily deployed to Test Pull Request October 23, 2024 16:34 — with GitHub Actions Inactive
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Additional details and impacted files

📢 Thoughts on this report? Let us know!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 23, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
508 0 2 508 100 1h27m5.650326s

didier-wenzek
didier-wenzek approved these changes Oct 23, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Ruadhri17 Ruadhri17 added this pull request to the merge queue Oct 23, 2024
Merged via the queue into thin-edge:main with commit 8eb090a Oct 23, 2024
@reubenmiller reubenmiller added theme:mqtt Theme: mqtt and mosquitto related topics theme:c8y Theme: Cumulocity related topics labels Oct 24, 2024
@Ruadhri17 Ruadhri17 mentioned this pull request Nov 6, 2024
Merged
11 tasks
@reubenmiller reubenmiller changed the title fix: replace hardcoded topic prefix for smartrest templates when creating bridge config fix: replace hardcoded topic prefix for SmartREST templates when creating bridge config Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@didier-wenzek didier-wenzek didier-wenzek approved these changes

@rina23q rina23q rina23q approved these changes

@albinsuresh albinsuresh Awaiting requested review from albinsuresh albinsuresh is a code owner

@jarhodes314 jarhodes314 Awaiting requested review from jarhodes314 jarhodes314 is a code owner

Assignees

No one assigned

Labels

theme:c8y Theme: Cumulocity related topics theme:mqtt Theme: mqtt and mosquitto related topics

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Ruadhri17 @didier-wenzek @rina23q @reubenmiller