Codecov Report

Attention: Patch coverage is 48.94958% with 243 lines in your changes missing coverage. Please review.

📢 Thoughts on this report? Let us know!

@rina23q What about changing the default credential location to the following, keeping in mind that it would allow us to add additional credentials to it (maybe in the future adding the c8y device bootstrapping credentials might be necessary).

Below is an example of using a single credentials file with multiple secrets, where keys are used to classify the secrets:

File

/etc/tedge/credentials

Contents

[c8y]
username = "octocat"
password = "abcd1234"

Robot Results

Flaky test update (resolved)

I did 20 iterations in my local for the suite smartrest_one suite by using the flake-finder.

invoke flake-finder --iterations 20 --outputdir output_flake_finder_3 --suite smartrest_one

The result was 9 passed, 11 failed. So, the test is absolutely flaky.

Failed iterations are: [2, 4, 6, 8, 9, 10, 11, 13, 14, 19, 20]

There were two patterns of failures.

1. NotAuthorized error in tedge connect c8y.

failed iterations

• build_in bridge: 4, 6, 9, 11, 13, 14,
• mosquitto bridge: 10, 20

cmd: ['/bin/sh', '-c', 'tedge connect c8y'], exit code: 1
stdout:
Using basic authentication.

Checking if systemd is available.

Validating the bridge certificates.

Creating the device in Cumulocity cloud.


stderr:
Detected mosquitto version >= 2.0.0
ERROR: ConnectionRefused(NotAuthorized)
Error: failed to connect to Cumulocity cloud.

Caused by:
    Connection check failed

2. Didn't receive a message onto the SmartREST1.0 subscription topic.

failed iterations

• build_in bridge:
• mosquitto bridge: 2, 8, 19

example output:

Should Have MQTT Messages   c8y/s/dl/${TEMPLATE_XID}    message_pattern=^800,\\d+,${mo["id"]}    timeout=10

Matching messages on topic 'c8y/s/dl/TST_Template_glare_internal_shore' is less than minimum.
wanted: 1
got: 0

messages:
[]

Update 1 [25.10.2024]

Pushed a new commit 06acbff to improve the stability of the tests. However, still failing.

Failed iterations: [8, 9, 11, 12, 13, 15, 19, 20] out of 20.

• Failed in tedge connect: 9, 12, 13, 15, 19, 20
• Failed in receiving on c8y/d/dl/{template}: 8, 11,

Note: iteration 11 also failed in configuration operation check. Error was
Expected operation (id=3829) to be SUCCESSFUL, but got: EXECUTING (failureReason: ). It was first time in total 80 attempts.

Update 2 (final) [29.10.2024]

The authorization issue was fully resolved. When the password contains $ and it's not end, it was wrongly parsed because of double quotes, e.g. 3pcrTLlzGAO23JPKop4$@. Changed from "${CREDENTIALS.password}" to '${CREDENTIALS.password}' solved the problem.

    Execute Command
    ...    cmd=printf '[c8y]\nusername = "%s"\npassword = "%s"\n' '${CREDENTIALS.username}' '${CREDENTIALS.password}' > /etc/tedge/credentials

The other message delivery issue's root cause is not 100% clear. Added tedge reconnect c8y after template registration, then publish a message with QoS 1 seems solved the problem.

    Execute Command    cmd=tedge mqtt pub --qos 1 c8y/s/ul/${TEMPLATE_XID} '339,${DEVICE_SN}'

LGTM.

A few other niggles that I observed during tedge connect:

Local MQTT publish has timed out.

Make sure mosquitto is running.
Failed to get the connected tenant URL from Cumulocity.

Users might get alarmed with such error messages. So, we'll have to hide or update some of these messages to account for basic auth based connections. BTW, since fetching the tenant URL from C8y failed, is that endpoint not supported while using basic auth?

This reported issue is resolved in b1ace67.