Skip to content

chore: Fix Rust 1.82 clippy lints#3195

Merged
Bravo555 merged 2 commits intothin-edge:mainfrom
Bravo555:chore/clippy-lints
Oct 18, 2024
Merged

chore: Fix Rust 1.82 clippy lints#3195
Bravo555 merged 2 commits intothin-edge:mainfrom
Bravo555:chore/clippy-lints

Conversation

@Bravo555
Copy link
Copy Markdown
Member

@Bravo555 Bravo555 commented Oct 18, 2024 •
edited
Loading

Proposed changes

Today, Rust 1.82 was published, which means there are new clippy lints breaking our CI that we get to fix. Yay 🎉

I also fixed lints present on nightly (1.84), so we should be good for a while.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@Bravo555
chore: fix clippy lints
5e635a8 
Signed-off-by: Marcel Guzik <marcel.guzik@inetum.com>
@Bravo555 Bravo555 temporarily deployed to Test Pull Request October 18, 2024 15:07 — with GitHub Actions Inactive
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 18, 2024 •
edited
Loading

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
509 0 2 509 100 1h33m57.391663999s

@reubenmiller reubenmiller added refactoring Developer value ci/cd Repository management and pipeline topics labels Oct 18, 2024
@Bravo555
doctests change function name to main
cc4c082 
Signed-off-by: Marcel Guzik <marcel.guzik@inetum.com>
@Bravo555 Bravo555 temporarily deployed to Test Pull Request October 18, 2024 15:50 — with GitHub Actions Inactive
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
crates/core/tedge/src/bridge/config.rs 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

📢 Thoughts on this report? Let us know!

didier-wenzek
didier-wenzek approved these changes Oct 18, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

crates/core/tedge_api/src/entity_store.rs
Comment on lines -33 to -40
/// Represents an "Entity topic identifier" portion of the MQTT topic
///
/// Example:
/// - topic: `te/device/dev1/service/myservice/m//my_measurement`
/// - entity id: `device/dev1/service/myservice`
///
/// <https://thin-edge.github.io/thin-edge.io/next/references/mqtt-api/#group-identifier>

Copy link
Copy Markdown
Contributor

@didier-wenzek didier-wenzek Oct 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to attach this definition to a type or a module, rather than remove it.

Copy link
Copy Markdown
Member Author

@Bravo555 Bravo555 Oct 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is for EntityTopicId. The struct was moved to another module along with the comment, but the comment in this module wasn't deleted.

thin-edge.io/crates/core/tedge_api/src/mqtt_topics.rs

Lines 275 to 292 in 0748986

/// Represents an "Entity topic identifier" portion of the MQTT topic
///
/// An entity identifier is a fixed 4-segment group, as such any 4 topic
/// segments that come after the root are considered a part of an identifier,
/// even if they contain values usually present in the channel group, e.g.
/// `/m/`.
///
/// If the topic ends before the expected 4 segments, the remaining segments are
/// filled by empty segments (`//`).
///
/// # Example
/// - topic: `te/device/dev1/service/myservice/m//my_measurement`
/// - entity id: `device/dev1/service/myservice`
///
/// # Reference
/// https://thin-edge.github.io/thin-edge.io/next/references/mqtt-api/#group-identifier
#[derive(Debug, Clone, Hash, PartialEq, Eq, Deserialize, Serialize)]
pub struct EntityTopicId(String);

@Bravo555 Bravo555 added this pull request to the merge queue Oct 18, 2024
Merged via the queue into thin-edge:main with commit cc2e384 Oct 18, 2024
@Bravo555 Bravo555 deleted the chore/clippy-lints branch October 21, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@didier-wenzek didier-wenzek didier-wenzek approved these changes

@albinsuresh albinsuresh Awaiting requested review from albinsuresh albinsuresh is a code owner

@jarhodes314 jarhodes314 Awaiting requested review from jarhodes314 jarhodes314 is a code owner

@rina23q rina23q Awaiting requested review from rina23q rina23q is a code owner

Assignees

No one assigned

Labels

ci/cd Repository management and pipeline topics refactoring Developer value

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Bravo555 @didier-wenzek @reubenmiller