fix: remove duplicate subscription in c8y built-in bridge#3188
Merged
reubenmiller merged 1 commit intothin-edge:mainfrom Oct 16, 2024
Merged
fix: remove duplicate subscription in c8y built-in bridge#3188reubenmiller merged 1 commit intothin-edge:mainfrom
reubenmiller merged 1 commit intothin-edge:mainfrom
Conversation
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Contributor
Robot Results
|
albinsuresh
approved these changes
Oct 16, 2024
didier-wenzek
approved these changes
Oct 16, 2024
Contributor
didier-wenzek
left a comment
There was a problem hiding this comment.
Approved.
We could also have something more systematic to remove the duplicates as this is done here
Contributor
Author
Yes, it would be a good improvement to also have a deduplication of topic subscriptions, but this can be done in a followup PR...this PR was just about the hardcoded duplication. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Removing a duplicate topic subscription when using the built-in bridge with Cumulocity.
The duplicate would cause some MQTT brokers (like nanomq) to deliver two messages (one per topic) which would ultimately result in duplicate telemetry data being created in Cumulocity.
The MQTT wildcard,
c8y/s/us/#, will also receive messages fromc8y/s/us.Types of changes
Paste Link to the issue
Checklist
cargo fmtas mentioned in CODING_GUIDELINEScargo clippyas mentioned in CODING_GUIDELINESFurther comments