Skip to content

fix: target incompatibility with armv6 package for raspberry pi#3182

Merged
reubenmiller merged 2 commits intothin-edge:mainfrom
reubenmiller:fix-armv6-builds
Oct 10, 2024
Merged

fix: target incompatibility with armv6 package for raspberry pi#3182
reubenmiller merged 2 commits intothin-edge:mainfrom
reubenmiller:fix-armv6-builds

Conversation

@reubenmiller
Copy link
Copy Markdown
Contributor

@reubenmiller reubenmiller commented Oct 10, 2024 •
edited
Loading

Proposed changes

Switch the armv6 package from using arm-unknown-linux-musleabihf to arm-unknown-linux-musleabi due to an issue being discovered with the format.

When using tedge compiled with the target arm-unknown-linux-musleabihf, an "illegal instruction" error whilst running tedge connect c8y.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

#3183

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@reubenmiller reubenmiller changed the title fix: fix a build issue with the armv6 raspberry pi images fix: fix target incompatibility with armv6 package for raspberry pi Oct 10, 2024
@reubenmiller reubenmiller changed the title fix: fix target incompatibility with armv6 package for raspberry pi fix: target incompatibility with armv6 package for raspberry pi Oct 10, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Additional details and impacted files

📢 Thoughts on this report? Let us know!

@reubenmiller reubenmiller marked this pull request as draft October 10, 2024 15:29
@reubenmiller
Copy link
Copy Markdown
Contributor Author

reubenmiller commented Oct 10, 2024

@didier-wenzek sorry the PR was meant to be in draft status as I want to build the new images on the CI and test it locally on the same device before merging it.

@reubenmiller
fix a build issue with the armv6 raspberry pi images
cc7bb91 
Using arm-unknown-linux-musleabihf lead to an "illegal instruction" error whilst running tedge connect

Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
@reubenmiller reubenmiller marked this pull request as ready for review October 10, 2024 16:12
@reubenmiller reubenmiller added the theme:packaging Theme: Packaging and release artefact topics label Oct 10, 2024
@reubenmiller
align docker image armv6 to new Rust target
3cd8d53 
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 10, 2024 •
edited
Loading

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
508 0 2 508 100 1h29m18.398847s

@reubenmiller reubenmiller added this pull request to the merge queue Oct 10, 2024
Merged via the queue into thin-edge:main with commit c5dcb29 Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Bravo555 Bravo555 Awaiting requested review from Bravo555 Bravo555 is a code owner

@rina23q rina23q Awaiting requested review from rina23q rina23q is a code owner

@didier-wenzek didier-wenzek Awaiting requested review from didier-wenzek

Assignees

No one assigned

Labels

theme:packaging Theme: Packaging and release artefact topics

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@reubenmiller @didier-wenzek