fix: Use tempfile in config-manager and downloader to ensure tmpfiles are always deleted#3178
Merged
Bravo555 merged 3 commits intothin-edge:mainfrom Oct 9, 2024
Conversation
Signed-off-by: Marcel Guzik <marcel.guzik@inetum.com>
Signed-off-by: Marcel Guzik <marcel.guzik@inetum.com>
As setting ownership is a privileged operation and all tedge services run as a regular user (except for tedge-write) the download crate probably shouldn't try `chown`ing them, as it can result in an error. Signed-off-by: Marcel Guzik <marcel.guzik@inetum.com>
Codecov ReportAttention: Patch coverage is Additional details and impacted files📢 Thoughts on this report? Let us know! |
rina23q
approved these changes
Oct 9, 2024
Member
rina23q
left a comment
There was a problem hiding this comment.
LGTM. I left a minor comment.
Contributor
Robot Results
|
tempfile in config-manager and downloader to ensure tmpfiles are always deletedtempfile in config-manager and downloader to ensure tmpfiles are always deleted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Replace manually created tempfiles with
.tmpsuffixes that didn't properly get clean up on errors withtempfilewhich delete on drop.Downloader and config manager should no longer leave temporary files if respective functions did not complete successfully.
Types of changes
Paste Link to the issue
Checklist
cargo fmtas mentioned in CODING_GUIDELINEScargo clippyas mentioned in CODING_GUIDELINESFurther comments