Skip to content

build: add support for building against specific gnu libc versions#3175

Merged
reubenmiller merged 1 commit intothin-edge:mainfrom
reubenmiller:build-allow-setting-gnu-libc-version
Oct 9, 2024
Merged

build: add support for building against specific gnu libc versions#3175
reubenmiller merged 1 commit intothin-edge:mainfrom
reubenmiller:build-allow-setting-gnu-libc-version

Conversation

@reubenmiller
Copy link
Copy Markdown
Contributor

@reubenmiller reubenmiller commented Oct 8, 2024

Proposed changes

Adjust the build.sh script to accept targets with the gnu libc version as a suffix.

This is a feature of cargo-zigbuild (see https://github.com/rust-cross/cargo-zigbuild?tab=readme-ov-file#specify-glibc-version). It is only intended for testing and experiments. It does not change the way the official binaries are built!

Examples

just release aarch64-unknown-linux-gnu.2.17

just release aarch64-unknown-linux-gnu.2.27

just release aarch64-unknown-linux-gnu.2.30

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

…go-ziglang (for testing/experiments only)

Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
@reubenmiller reubenmiller requested a review from Bravo555 as a code owner October 8, 2024 13:37
@reubenmiller reubenmiller changed the title build: add support for building against specific gnu libc versions using cargo-ziglang (for testing/experiments only) build: add support for building against specific gnu libc versions Oct 8, 2024
@reubenmiller reubenmiller added the theme:developer-exp Theme: improve developer experience label Oct 8, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 8, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
508 0 2 508 100 1h44m27.556103999s

Copy link
Copy Markdown
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@reubenmiller reubenmiller added this pull request to the merge queue Oct 9, 2024
Merged via the queue into thin-edge:main with commit daef5e3 Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

theme:developer-exp Theme: improve developer experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants