Skip to content

dev: update packages in dev container image#3172

Merged
reubenmiller merged 3 commits intothin-edge:mainfrom
reubenmiller:dev-container-dep
Oct 8, 2024
Merged

dev: update packages in dev container image#3172
reubenmiller merged 3 commits intothin-edge:mainfrom
reubenmiller:dev-container-dep

Conversation

@reubenmiller
Copy link
Copy Markdown
Contributor

Proposed changes

Update packages and add additional tools in the dev container image:

  • Update nodejs to v20
  • Install wget
  • Install json tools (jq and jo)
  • Install mosquitto from bookworm-backports instead of sid
  • Install utilities like ssh, sudo, gnupg2, net-tools, netcat
  • Remove systemd policies (aligning to the system test image)

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
@reubenmiller reubenmiller added the theme:developer-exp Theme: improve developer experience label Oct 8, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 8, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
508 0 2 508 100 1h36m7.295268s

@reubenmiller reubenmiller requested a review from Ruadhri17 October 8, 2024 07:08
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Copy link
Copy Markdown
Contributor

@Ruadhri17 Ruadhri17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reubenmiller reubenmiller marked this pull request as ready for review October 8, 2024 13:00
@reubenmiller reubenmiller enabled auto-merge October 8, 2024 13:00
@reubenmiller reubenmiller added this pull request to the merge queue Oct 8, 2024
Merged via the queue into thin-edge:main with commit cfb537d Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

theme:developer-exp Theme: improve developer experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants