Skip to content

test: format robotframework system tests#3169

Merged
reubenmiller merged 1 commit intothin-edge:mainfrom
reubenmiller:test-format-code
Oct 7, 2024
Merged

test: format robotframework system tests#3169
reubenmiller merged 1 commit intothin-edge:mainfrom
reubenmiller:test-format-code

Conversation

@reubenmiller
Copy link
Copy Markdown
Contributor

@reubenmiller reubenmiller commented Oct 7, 2024

Proposed changes

Format Robotframework system tests using robotframework-tidy.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@reubenmiller reubenmiller requested review from a team and gligorisaev as code owners October 7, 2024 14:21
@reubenmiller
format robotframework system tests
2b31820 
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
rina23q
rina23q approved these changes Oct 7, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@rina23q rina23q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we have a PR check like cargo-fmt?

@reubenmiller
Copy link
Copy Markdown
Contributor Author

reubenmiller commented Oct 7, 2024

Don't we have a PR check like cargo-fmt?

We should, but looking at the workflow, it only rust cargo-fmt instead just format-check. But I will address in a follow up PR.

@reubenmiller reubenmiller added the theme:testing Theme: Testing label Oct 7, 2024
@reubenmiller reubenmiller enabled auto-merge October 7, 2024 14:38
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 7, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
508 0 2 508 100 1h29m34.777046s

@reubenmiller reubenmiller added this pull request to the merge queue Oct 7, 2024
Merged via the queue into thin-edge:main with commit c11945c Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rina23q rina23q rina23q approved these changes

@gligorisaev gligorisaev Awaiting requested review from gligorisaev

Assignees

No one assigned

Labels

theme:testing Theme: Testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@reubenmiller @rina23q